Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos shared through link display incorrectly after hitting the full screen button on iOS Safari #697

Open
ChildLearningClub opened this issue Jun 19, 2023 · 8 comments
Labels
blocked Needs fix or release upstream viewer Issues related to the photo viewer
Milestone

Comments

@ChildLearningClub
Copy link
Sponsor

Describe the bug

when setting video to full screen it does not actually go full screen

To Reproduce
play a video in the browser and hit the full screen button when on iOS Safari, the icon changes, but the video remains non-fullscreen

Screenshots

RPReplay_Final1687136907.mov

Platform:

  • OS: iOS
  • Browser: Safari
  • Memories Version: 5.1.0
  • Nextcloud Version: 27
  • PHP Version: 8.2.7

Additional context
I have found this to be the case with other programs that also do not implement the fullscreen correctly for iOS Safari. The example of it implemented correctly is in the Jellyfin program.

  • Any errors in the JS console?
  • Any errors in the Nextcloud server logs?
@ChildLearningClub ChildLearningClub added the needs triage To be triaged label Jun 19, 2023
@pulsejet pulsejet added bug Something isn't working viewer Issues related to the photo viewer and removed needs triage To be triaged labels Jun 19, 2023
@meichthys
Copy link
Contributor

meichthys commented Jul 31, 2023

Fullscreen does work for me on android (grapheneos) with chromium (vanadium), so perhaps this is limited to iOS.

@ChildLearningClub
Copy link
Sponsor Author

@pulsejet I’m happy to test any builds. Currently playback of video on an iOS through Safari is a really bad experience. I did notice that in the case of Jellyfin, as I posted above, that when going full screen it appears that Jellyfin is dropping its player and playing directly from the iPhones built in player. Is there some reason this is not possible within Nextcloud?

RPReplay_Final1702105414.mov

@pulsejet pulsejet added this to the 6.2 milestone Dec 10, 2023
@pulsejet pulsejet added the blocked Needs fix or release upstream label Jan 10, 2024
@pulsejet
Copy link
Owner

iPhones don't support fullscreen: https://caniuse.com/fullscreen

Safari should just die at this point 😞

@pulsejet pulsejet removed the bug Something isn't working label Jan 10, 2024
@pulsejet pulsejet modified the milestones: 6.2, 6.3 Jan 10, 2024
@ChildLearningClub
Copy link
Sponsor Author

From what I have seen Safari is not very developer friendly :(. I know I keep referencing Jellyfin, but it is clear is the first video and the initial post above ☝️ that it is possible to play videos in full screen on iOS devices. It does not look like they are being played in the Safari browser but rather played from the iOS devices native built in video player possibly through its API https://developer.apple.com/documentation/webkitjs/htmlvideoelement/1630493-webkitdisplayingfullscreen So I’m sure there is a way to do this.

@pulsejet
Copy link
Owner

That's right, native apps can do this but not web apps. There's simply no fullscreen API (funnily enough, the fullscreen API supposedly works on iPads but not iPhones)

@ChildLearningClub
Copy link
Sponsor Author

https://media.childlearning.club/web/index.html#!/video

This is a web app playing in full screen and it goes full screen on iOS playing any of these videos.

@ChildLearningClub
Copy link
Sponsor Author

Sorry I should be more specific about the issue. Your app when download to the iOS Home Screen as a progressive web app works well and will play the videos in full screen perfectly fine. The issue above is with a shared video through a link. When I open the shared video in the browser it displays as you can see in the videos I posted above.

@ChildLearningClub ChildLearningClub changed the title full screen not working on mobile Videos shared through link display incorrectly after hitting the full screen button on iOS Safari Jan 11, 2024
@ChildLearningClub
Copy link
Sponsor Author

Also something was changed in Memories between when I first created this issue and my second post where things got wonky. Initially it was simply that the full screen button had no effect. Now it’s that the video margins get all messed up. With the video getting stuck in the top right corner. Only way to fix it is to refresh the page and not touch the full screen button.

RPReplay_Final1702105414.mov

@pulsejet pulsejet modified the milestones: 7.0, 7.1 Mar 20, 2024
@pulsejet pulsejet modified the milestones: 7.1, 7.2, 7.3 Apr 3, 2024
@pulsejet pulsejet modified the milestones: 7.3, 7.4 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Needs fix or release upstream viewer Issues related to the photo viewer
Projects
None yet
Development

No branches or pull requests

3 participants