Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Safari display issues #1092

Open
ChildLearningClub opened this issue Mar 24, 2024 · 6 comments
Open

iOS Safari display issues #1092

ChildLearningClub opened this issue Mar 24, 2024 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@ChildLearningClub
Copy link
Sponsor

ChildLearningClub commented Mar 24, 2024

Describe the bug

You will notice two separate things that could be fixed

  1. Landscape mode not taking up entire screen
  2. When changing from landscape to portrait bottom is cut, requiring refresh of page to fix.

To Reproduce

Share and open public link on iOS Safari

Screenshots

Quick comparison of both Photos and Memories public link displaying on iOS Safari

RPReplay_Final1711232322_1.mp4

Platform:

iOS Safari

Additional context

Although not the same issue as Fullscreen not working, but related I think
#697

@ChildLearningClub ChildLearningClub added the needs triage To be triaged label Mar 24, 2024
@pulsejet
Copy link
Owner

Safari 😭

@pulsejet pulsejet added bug Something isn't working and removed needs triage To be triaged labels Mar 24, 2024
@pulsejet pulsejet added this to the 7.1 milestone Mar 24, 2024
@pulsejet
Copy link
Owner

pulsejet commented Mar 25, 2024

One note:

Landscape mode not taking up entire screen

This is kinda intentional; that gap is the scroller (same as desktop). Maybe it might make more sense to never show the scroller on mobile devices, but it's not clear what's the better interface on e.g. iPads say with a mouse

@ChildLearningClub
Copy link
Sponsor Author

One note:

Landscape mode not taking up entire screen

This is kinda intentional; that gap is the scroller (same as desktop). Maybe it might make more sense to never show the scroller on mobile devices, but it's not clear what's the better interface on e.g. iPads say with a mouse

Oh I was referring to the URL bar and other open tabs becoming visible when changing to landscape, you will notice in the video that this does not happen with the Photos app.

@pulsejet
Copy link
Owner

When changing from landscape to portrait bottom is cut, requiring refresh of page to fix.

So I did manage to reproduce this intermittently, but it seems like a bug in Webkit. Safari is actually calling ResizeObserver callbacks with wrong heights, and some of the subsequent calls get dropped for whatever reason; either way this seems like something Apple needs to fix

@ChildLearningClub
Copy link
Sponsor Author

I’m curious why this doesn’t happen with again the Photos app for example?

pulsejet added a commit that referenced this issue Mar 26, 2024
Signed-off-by: Varun Patil <radialapps@gmail.com>
@pulsejet
Copy link
Owner

Implemented a possibly unrelated fix; I can't reproduce the issue anymore (though it was sporadic for me to begin with)

I’m curious why this doesn’t happen with again the Photos app for example?

Photos uses a completely different (and much simpler) design -- it plays a bit nicer with the browser but is much slower and doesn't support lazy loading.

@pulsejet pulsejet modified the milestones: 7.1, 7.2, 7.3 Apr 3, 2024
@pulsejet pulsejet modified the milestones: 7.3, 7.4 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants