Skip to content

Commit

Permalink
fix: remove pulumi-version default (#1208)
Browse files Browse the repository at this point in the history
The default value is conflicting with the new `pulumi-version-file`
option. Also, we are defaulting the version in the code here, so we
don't need the default to be set by the action.
https://github.com/pulumi/actions/blob/19cc848d9c6fb4ac618050ff0ab3272d1ddec7b4/src/config.ts#L44
  • Loading branch information
corymhall committed Jun 25, 2024
1 parent 707169d commit d41dd46
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## HEAD (Unreleased)

- fix: remove `pulumi-version` default
((#1208)[https://github.com/pulumi/actions/pull/1208])

---

## 5.3.0 (2024-06-25)
Expand Down
1 change: 0 additions & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ inputs:
pulumi-version:
description: 'Install a specific version of the Pulumi CLI'
required: false
default: '^3'
pulumi-version-file:
description: 'File containing the version of the Pulumi CLI to install. Example: .pulumi.version'
required: false
Expand Down
3 changes: 2 additions & 1 deletion dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export function makeConfig() {
] as const,
}),
stackName: getInput('stack-name', { required: true }),
pulumiVersion: getInput('pulumi-version', { required: true }),
pulumiVersion: getInput('pulumi-version') ?? '^3',
workDir: getInput('work-dir', { required: true }),
secretsProvider: getInput('secrets-provider'),
cloudUrl: getInput('cloud-url'),
Expand Down

0 comments on commit d41dd46

Please sign in to comment.