Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bar hides headings via anchors #1709

Closed
clstokes opened this issue Sep 9, 2019 · 4 comments · Fixed by #1771
Closed

Navigation bar hides headings via anchors #1709

clstokes opened this issue Sep 9, 2019 · 4 comments · Fixed by #1771
Assignees
Milestone

Comments

@clstokes
Copy link
Contributor

clstokes commented Sep 9, 2019

Can we offset the anchor links for Resources (and other) headings in our SDK docs?

When I click one of the resource links on our API pages, I'm taken to the resource, but it's heading is hidden underneath the nav element and not immediately obvious that I was taken to the resource.

Example for https://www.pulumi.com/docs/reference/pkg/nodejs/pulumi/eks/#ServiceRole:
Screen Recording 2019-09-09 at 16 04 00 2019-09-09 16_05_16

@justinvp
Copy link
Member

The simple fix would be to stop fixing the nav bar at the top. Is that really needed?

@clstokes
Copy link
Contributor Author

In my opinion, no, it's not needed. @joeduffy ?

@joeduffy
Copy link
Member

I would like to keep it anchored. The primary goal is to keep the CTA visible at all times. A number of other exemplar blogs do this and was an explicit tip from marketing folks we've spoken to.

@joeduffy
Copy link
Member

Here is an example of a site that handles this gracefully: https://www.confluent.io/blog/kafka-rebalance-protocol-static-membership#opt-into-static-membership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants