Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check in Typescript generated artifacts #19

Closed
chrsmith opened this issue Nov 7, 2017 · 3 comments
Closed

Don't check in Typescript generated artifacts #19

chrsmith opened this issue Nov 7, 2017 · 3 comments
Assignees
@chrsmith
Labels
p0 A bug severe enough to interrupt existing work
Milestone
0.15

Comments

@chrsmith
Copy link
Contributor

chrsmith commented Nov 7, 2017

Today we check in the results of make generate into the /packages folder. But this generally isn't want we do for generated sources.

Let's back out those files, and then just add the script or two needed to build/sync the various dependent repos so that make generate does all it needs to.
@chrsmith chrsmith added this to the 0.9 milestone Nov 7, 2017
@joeduffy joeduffy modified the milestones: 0.9, 0.11 Nov 21, 2017
@lindydonna lindydonna changed the title Don't check in build artifacts Don't check in Typescript generated artifacts Jan 5, 2018
@joeduffy joeduffy modified the milestones: 0.11, 0.12 Feb 20, 2018
@ericrudder ericrudder modified the milestones: 0.12, 0.15 Mar 15, 2018
@ericrudder
Copy link
Member

good hygiene feature

@lindydonna
Copy link
Contributor

@joeduffy We do need a plan for whether and how to surface docs for old SDK versions. Please review Generated files and reference docs

@lindydonna
Copy link
Contributor

Closing in favor of #246

@infin8x infin8x added the p0 A bug severe enough to interrupt existing work label Jul 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrsmith chrsmith

Labels
p0 A bug severe enough to interrupt existing work
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
5 participants
@infin8x @joeduffy @chrsmith @lindydonna @ericrudder