Update Step 2 C# Example #3208
Merged
Update Step 2 C# Example #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried following this example and ran in to multiple potential issues. - The initial tutorial puts all of the code in to the `MyStack.cs` class, and the run is only using that file for all of the updates. The description in Step 2, describes putting the code in to `MyStack.cs` but the code snippet is putting everything in `Program.cs`. - Even if using `Program.cs`, it would need to be `Deployment.RunAsync`, there's a compiler error with a straight copy/paste - There's a syntax issue when specifying the `SecurityGroupIngressArgs`, there's an extra set of curly brackets that I've removed - The line for specifying the `ami.Id` will not work unless you get the `.Result` of the `GetAmi.InvokeAsync`. Without, `ami.Id` just returns `1`. Is there a better way to fix this? I always try to avoid doing `.Result`, but not sure how you want to approach that in this case. - I added the two `[Output]` properties for `PublicIp` and `PublicDns` Please feel free to take another approach with this, this is just what I had to do in order to get the tutorial working as I believe it was intended to. I'm also happy to make any adjustments to this PR if that would help you out. If I did something wrong and the tutorial _is_ working as intended the way it is on the site right now, please let me know so I can adjust for future reference. Thanks!
|
@efleming18 Thanks for the PR! These tutorials are unfortunately outdated and didn't get any love after the recent changes. I believe we can copy the code from https://github.com/pulumi/examples/blob/master/aws-cs-webserver/WebServerStack.cs - this would avoid using |
|
I added some updates based on your feedback, @mikhailshilkov - if there's anything else I need to do for it, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried following this example and ran in to multiple potential issues.
MyStack.csclass, and the run is only using that file for all of the updates. The description in Step 2, describes putting the code in toMyStack.csbut the code snippet is putting everything inProgram.cs.Program.cs, it would need to beDeployment.RunAsync, there's a compiler error with a straight copy/pasteSecurityGroupIngressArgs, there's an extra set of curly brackets that I've removedami.Idwill not work unless you get the.Resultof theGetAmi.InvokeAsync. Without,ami.Idjust returns1. Is there a better way to fix this? I always try to avoid doing.Result, but not sure how you want to approach that in this case.[Output]properties forPublicIpandPublicDnsSecurityGroupswhich is apparently deprecated to useVpcSecurityGroupIds. This appears to have worked like normal, but would definitely like for you to confirm.Please feel free to take another approach with this, this is just what I had to do in order to get the tutorial working as I believe it was intended to. I'm also happy to make any adjustments to this PR if that would help you out.
If I did something wrong and the tutorial is working as intended the way it is on the site right now, please let me know so I can adjust for future reference.
Thanks!