Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix help text for esc env edit #25

Closed
pgavlin opened this issue Oct 4, 2023 · 1 comment · Fixed by #42
Closed

cli: fix help text for esc env edit #25

pgavlin opened this issue Oct 4, 2023 · 1 comment · Fixed by #42
Assignees
@pgavlin
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.95

Comments

@pgavlin
Copy link
Member

pgavlin commented Oct 4, 2023

Replace "Opens an environment for editing" with "Edits an environment's definition"
@pgavlin pgavlin self-assigned this Oct 5, 2023
@pgavlin pgavlin mentioned this issue Oct 5, 2023
Merged
pgavlin added a commit that referenced this issue Oct 5, 2023
@pgavlin
cli: env edit fixes (#42)
8f12f9d 
- Do not lose edits when the new YAML contains errors
- Automatically append "-w" to the editor if it is `code`
- Default to `vi` if no other editor is present
- Fix the help text to remove the term 'open'

Fixes #25.
Fixes #27.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 5, 2023
@pulumi-bot pulumi-bot reopened this Oct 5, 2023
@pulumi-bot
Copy link

Cannot close issue:

  • does not have required labels: kind/

Please fix these problems and try again.

@pgavlin pgavlin added the kind/bug Some behavior is incorrect or out of spec label Oct 5, 2023
@pgavlin pgavlin closed this as completed Oct 5, 2023
@cleverguy25 cleverguy25 added this to the 0.95 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgavlin pgavlin

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.95
Development

Successfully merging a pull request may close this issue.

cli: env edit fixes pulumi/esc
3 participants
@pgavlin @cleverguy25 @pulumi-bot