Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in cache when POSTing url with same key #13

Closed
lindydonna opened this issue Feb 8, 2018 · 1 comment
Closed

Fix bug in cache when POSTing url with same key #13

lindydonna opened this issue Feb 8, 2018 · 1 comment
Assignees
@lukehoban
Labels
area/examples kind/bug Some behavior is incorrect or out of spec
Milestone
0.14

Comments

@lindydonna
Copy link
Contributor

Since the UI allows a POST with a duplicate key which results in the Table being updated, the redis cache key also needs to be deleted.
@lindydonna lindydonna added area/examples kind/bug Some behavior is incorrect or out of spec labels Feb 8, 2018
@lindydonna lindydonna self-assigned this Feb 8, 2018
@lindydonna lindydonna added this to the 0.11 milestone Feb 8, 2018
@joeduffy joeduffy modified the milestones: 0.11, 0.12 Feb 12, 2018
@lindydonna
Copy link
Contributor Author

@lukehoban Should I push this out until we've settled on our pulumi/cloud "refactor"? I imagine this sample might change quite a bit.

@lukehoban lukehoban assigned lukehoban and unassigned lindydonna Apr 18, 2018
@lukehoban lukehoban modified the milestones: 0.12, 0.14 Apr 23, 2018
lukehoban added a commit that referenced this issue Apr 23, 2018
@lukehoban
Updates to url shortener w/ cache example
db74a18 
Use latest @pulumi/cloud API, including not using `getEndpoint` in deployment code.

Use 302 instead of 301 for redirects, since we allow changes to the indirection.

Use config without `:config` part to avoid deprecation warning.

Update the cache as well as the table in POST handler.

Fixes #13.
@lukehoban lukehoban mentioned this issue Apr 23, 2018
Merged
lukehoban added a commit that referenced this issue Apr 23, 2018
@lukehoban
Updates to url shortener w/ cache example
b89703a 
Use latest @pulumi/cloud API, including not using `getEndpoint` in deployment code.

Use 302 instead of 301 for redirects, since we allow changes to the indirection.

Update the cache as well as the table in POST handler.

Fixes #13.
lukehoban added a commit that referenced this issue Apr 23, 2018
@lukehoban
Updates to url shortener w/ cache example (#45)
7b07c07 
Use latest @pulumi/cloud API, including not using `getEndpoint` in deployment code.

Use 302 instead of 301 for redirects, since we allow changes to the indirection.

Update the cache as well as the table in POST handler.

Fixes #13.
ramene pushed a commit to ramene/pulumi-kubeflow-ml that referenced this issue Sep 7, 2019
@lukehoban
Updates to url shortener w/ cache example (pulumi#45)
5883984 
Use latest @pulumi/cloud API, including not using `getEndpoint` in deployment code.

Use 302 instead of 301 for redirects, since we allow changes to the indirection.

Update the cache as well as the table in POST handler.

Fixes pulumi#13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukehoban lukehoban

Labels
area/examples kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
0.14
Development

No branches or pull requests
3 participants
@lukehoban @joeduffy @lindydonna