Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go, Node, and Python versions for perf benchmarks #1433

Merged
merged 1 commit into from
May 31, 2023

Conversation

justinvp
Copy link
Member

Bump Go, Node, and Python versions for perf benchmarks to use the same versions used in other workflows in this repo, e.g.:

matrix:
dotnetversion:
- 3.1.301
goversion:
- 1.19.x
nodeversion:
- 16.x
platform:
- ubuntu-latest
pythonversion:
- "3.9"

Fixes #1431

Bump Go, Node, and Python versions for perf benchmarks to use the same versions used in other workflows in this repo.
@pulumi-staging
Copy link

❌ The Update for moolumi/k8s-ci-cluster/8297869b2f09488c882a47c302519e5720e72a63-1412 failed.

Resource Changes

    Name                  Type                                        Operation
+   multicloud            pulumi-kubernetes:ci:GkeCluster             create
+   password              random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster  gcp:container/cluster:Cluster               create

@@ -106,10 +106,10 @@ jobs:
dotnet-version:
- 3.1.301
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It looks like this will need to be bumped to .NET 6 as part of fixing TestAccAwsCsS3Folder and TestAccAwsFsS3Folder for #1430 due to:

https://github.com/pulumi/examples/actions/runs/5090579201/jobs/9149574791#step:15:77

error NU1202: Package Pulumi.Aws 5.41.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Pulumi.Aws 5.41.0 supports: net6.0 (.NETCoreApp,Version=v6.0)

I'll do that as part of #1430

@justinvp justinvp merged commit 32d9047 into master May 31, 2023
34 of 49 checks passed
@justinvp justinvp deleted the justin/perf_deps branch May 31, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI performance metrics TestManyResources examples broken
2 participants