Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go example for AWS Fargate #1440

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix Go example for AWS Fargate #1440

merged 1 commit into from
Jun 20, 2023

Conversation

scottslowe
Copy link
Contributor

This PR improves the Go example for AWS Fargate with a number of changes:

Remove dependency on default VPC. Switch to Docker 4.x provider. Fix issue when building from ARM64-based systems. Improve comments.

Signed-off-by: Scott Lowe <slowe@pulumi.com>
@scottslowe scottslowe requested a review from a team June 20, 2023 19:00
@scottslowe scottslowe self-assigned this Jun 20, 2023
@pulumi-staging
Copy link

❌ The Update for moolumi/k8s-ci-cluster/81116d8e0ad3fa4f19681962150f8300c9ab6c74-1414 failed.

Resource Changes

    Name                  Type                                        Operation
+   multicloud            pulumi-kubernetes:ci:GkeCluster             create
+   password              random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster  gcp:container/cluster:Cluster               create

Copy link
Member

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@scottslowe scottslowe added this to the 0.90 milestone Jun 20, 2023
@scottslowe scottslowe merged commit 3cf932d into master Jun 20, 2023
35 of 49 checks passed
@scottslowe scottslowe deleted the slowe/fix-aws-go-fargate branch June 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants