Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitchgerdisch/fix integration test program #1442

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

MitchellGerdisch
Copy link
Contributor

The Pulumi program being tested was using an old version of the aws provider and needed another resource to allow the policy to be added to the bucket. So updated that.
Also there were some deprecation warnings related to some of the go libraries. So updated that.

Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem reasonable, approved. Double-check the failures in the checks to be sure they aren't caused by your changes.

@MitchellGerdisch
Copy link
Contributor Author

Thanks for the review.
None of the failed checks are related.

@MitchellGerdisch MitchellGerdisch merged commit bc9b7e7 into master Jun 23, 2023
36 of 50 checks passed
@MitchellGerdisch MitchellGerdisch deleted the mitchgerdisch/fix-integration-test-program branch June 23, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants