Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use astro as website builder for the monorepo example #1610

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Mar 12, 2024

In preparation for a blog post, use Astro to build the website and reorganise the components.

@julienp julienp requested a review from a team March 13, 2024 16:14
@julienp julienp marked this pull request as ready for review March 13, 2024 16:14
Copy link

@PollRobots PollRobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good a few minor nits.

I notice that you are using let and const somewhat indiscriminately in the typescript. I don't see (although I could be wrong) any place in this code where you need let,

nx-monorepo/README.md Outdated Show resolved Hide resolved
nx-monorepo/components/website-deploy/index.ts Outdated Show resolved Hide resolved
nx-monorepo/README.md Outdated Show resolved Hide resolved
@julienp julienp force-pushed the julienp/update-nx-monorepo-example branch from 019a15b to d74695b Compare March 14, 2024 09:28
@julienp julienp merged commit 146c189 into master Mar 14, 2024
49 of 51 checks passed
@julienp julienp deleted the julienp/update-nx-monorepo-example branch March 14, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants