Adds Docker Build provider examples using Docker Build Cloud #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desteves
changed the title
desteves
changed the title
added 2 commits
May 8, 2024 13:43
jkodroff
reviewed
May 10, 2024
There was a problem hiding this comment.
Suggest renaming aws-ts-containers-dbc aws-ts-ecr-dockerbuild or something? The Docker Build provider part needs to pop IMO since that's the key technology and I'm not sure that dbc is something people would know.
Leaving this review as comment in case I'm off-base with the request change to remove CTAs.
Co-authored-by: Josh Kodroff <jkodroff@users.noreply.github.com>
Co-authored-by: Josh Kodroff <jkodroff@users.noreply.github.com>
Co-authored-by: Josh Kodroff <jkodroff@users.noreply.github.com>
This was to align with the current I went with |
added 3 commits
May 10, 2024 13:22
desteves
changed the title
jkodroff
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new examples using the Docker Build provider to build a Docker image using Docker Build Cloud (DBC) in Typescript.
dockerbuildcloud-ts- Builds a Docker Image from an NGINX local Dockerfile. This template prompts the user for an existing DBC builder.aws-ts-containers-dockerbuildcloud- This is a slight variation of the existingaws-ts-containersbut with the new Docker Build provider and Docker Build Cloud.These examples are (will be) referenced in an upcoming blogpost.