Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Deploy button fixes #1642

Merged
merged 1 commit into from
May 21, 2024
Merged

More Deploy button fixes #1642

merged 1 commit into from
May 21, 2024

Conversation

cnunciato
Copy link
Member

@cnunciato cnunciato commented May 21, 2024 •
edited
Loading

Handful of quick changes to make the repo more compatible with imported examples guides:

  • Uses the updated buttons from get.pulumi.com instead of www (I added a light button there as well)
  • Removes some duplicate buttons (e.g., to fix things like this)
  • Adds light-mode buttons where there aren't any for consistency

@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/258fe8d2345524dd718d6f74af71565c75df23a6-1767 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-258fe8d2345524dd718d6f74af71565c75df23a6-1767  pulumi:pulumi:Stack                         create
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create

@cnunciato cnunciato force-pushed the cnunciato/more-button-fixes branch 2 times, most recently from 001a66e to 6146586 Compare May 21, 2024 19:49
@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/8d716cc9cc2f52fd2d6aa72bddf853daa70b8f86-1768 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-8d716cc9cc2f52fd2d6aa72bddf853daa70b8f86-1768  pulumi:pulumi:Stack                         create

@cnunciato cnunciato force-pushed the cnunciato/more-button-fixes branch from 6146586 to a603656 Compare May 21, 2024 19:53
@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/2f31b2675fd87a66a77dd8d0eef55d29c47fb371-1769 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-2f31b2675fd87a66a77dd8d0eef55d29c47fb371-1769  pulumi:pulumi:Stack                         create
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create

@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/258fe8d2345524dd718d6f74af71565c75df23a6-1767 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-258fe8d2345524dd718d6f74af71565c75df23a6-1767  pulumi:pulumi:Stack                         delete
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete

@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/fdda9e94cd2e41704c3bc78f9a731da94e2cf2a6-1770 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-fdda9e94cd2e41704c3bc78f9a731da94e2cf2a6-1770  pulumi:pulumi:Stack                         create
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create

@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/8d716cc9cc2f52fd2d6aa72bddf853daa70b8f86-1768 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-8d716cc9cc2f52fd2d6aa72bddf853daa70b8f86-1768  pulumi:pulumi:Stack                         delete
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete

@cnunciato cnunciato force-pushed the cnunciato/more-button-fixes branch from a603656 to 67872db Compare May 21, 2024 20:26
@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/2f31b2675fd87a66a77dd8d0eef55d29c47fb371-1769 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-2f31b2675fd87a66a77dd8d0eef55d29c47fb371-1769  pulumi:pulumi:Stack                         delete
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete

@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/fdda9e94cd2e41704c3bc78f9a731da94e2cf2a6-1770 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-fdda9e94cd2e41704c3bc78f9a731da94e2cf2a6-1770  pulumi:pulumi:Stack                         delete

@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/46d737e39168e80a8703a4281b9e9714106eb93c-1771 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   k8s-ci-cluster-46d737e39168e80a8703a4281b9e9714106eb93c-1771  pulumi:pulumi:Stack                         create
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create

@cnunciato cnunciato force-pushed the cnunciato/more-button-fixes branch 2 times, most recently from f45998e to cfcfea3 Compare May 21, 2024 21:08
@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/82f3164a6e779a9a22aa63c31862bd9f0e5eea9a-1772 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-82f3164a6e779a9a22aa63c31862bd9f0e5eea9a-1772  pulumi:pulumi:Stack                         create

@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/46d737e39168e80a8703a4281b9e9714106eb93c-1771 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-46d737e39168e80a8703a4281b9e9714106eb93c-1771  pulumi:pulumi:Stack                         delete

@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/ab1f0c3500c8100055273ef5c5436d5fa2d1d780-1773 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-ab1f0c3500c8100055273ef5c5436d5fa2d1d780-1773  pulumi:pulumi:Stack                         create

@cnunciato cnunciato force-pushed the cnunciato/more-button-fixes branch from cfcfea3 to 7903c43 Compare May 21, 2024 21:25
@cnunciato cnunciato force-pushed the cnunciato/more-button-fixes branch from 7903c43 to 86f5879 Compare May 21, 2024 21:39
@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/eda538230dcb2f79726d02ede7314d3edce418d3-1774 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-eda538230dcb2f79726d02ede7314d3edce418d3-1774  pulumi:pulumi:Stack                         create
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create

@cnunciato cnunciato marked this pull request as ready for review May 21, 2024 21:41
@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/82f3164a6e779a9a22aa63c31862bd9f0e5eea9a-1772 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-82f3164a6e779a9a22aa63c31862bd9f0e5eea9a-1772  pulumi:pulumi:Stack                         delete

@sean1588 sean1588 self-requested a review May 21, 2024 21:48
sean1588
sean1588 approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and good catch with the duplicate buttons.

@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/ab1f0c3500c8100055273ef5c5436d5fa2d1d780-1773 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-ab1f0c3500c8100055273ef5c5436d5fa2d1d780-1773  pulumi:pulumi:Stack                         delete

@pulumi-staging Pulumi Staging
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/ffed193efc4a2a8671dfe478e175a0a8ab9a3316-1775 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-ffed193efc4a2a8671dfe478e175a0a8ab9a3316-1775  pulumi:pulumi:Stack                         create

@cnunciato cnunciato merged commit 5f3eae8 into master May 21, 2024
47 of 48 checks passed
@cnunciato cnunciato deleted the cnunciato/more-button-fixes branch May 21, 2024 22:04
@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/eda538230dcb2f79726d02ede7314d3edce418d3-1774 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-eda538230dcb2f79726d02ede7314d3edce418d3-1774  pulumi:pulumi:Stack                         delete
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete

@pulumi-staging Pulumi Staging
Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/ffed193efc4a2a8671dfe478e175a0a8ab9a3316-1775 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-ffed193efc4a2a8671dfe478e175a0a8ab9a3316-1775  pulumi:pulumi:Stack                         delete
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean1588 sean1588 sean1588 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cnunciato @sean1588