Update examples to Command provider 1.0 #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
approved these changes
Jun 27, 2024
| "@pulumi/azure": "^4.0.0", | ||
| "@pulumi/command": "^0.0.3", | ||
| "@pulumi/azure": "^5.0.0", | ||
| "@pulumi/command": "1.0.0-beta.1", |
There was a problem hiding this comment.
Looks like this example may not be covered by tests in misc/tests? Is it worth adding it there to make sure these changes work and that we don’t regress in the future?
There was a problem hiding this comment.
That's a good catch. Unfortunately, it needs some setup to provide an SSH key pair. In AWS, we have ec2.CreateKeyPair but I can't see an equivalent in Azure. We could probably generate a pair locally and store it as a GH secret but I don't have the rights to do so in p/examples - will work with @cnunciato.
There was a problem hiding this comment.
Filed #1658 so we don't lose track of it and I can merge this PR.
thomas11
force-pushed
the
tkappler/command-1.0
branch
2 times, most recently
from
914e332
to
9287bca
Compare
thomas11
force-pushed
the
tkappler/command-1.0
branch
2 times, most recently
from
4d2a30c
to
67ed7bd
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all examples that use the Command provider to use
1.0-beta.11.0.0.Note on Java: there are no Command-related changes but the example doesn't compile with the
sourceversion set to less than 15 so I fixed that.