Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update classic-azure-ts-vm-scaleset to latest major version 5 and remove retired email notifications #1655

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update classic-azure-ts-vm-scaleset to latest major version 5 and remove retired email notifications #1655

merged 1 commit into from
Jul 2, 2024

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Jul 1, 2024 •
edited
Loading

This example was persistently failing tests with

    azure:monitoring:AutoscaleSetting (vmss-autoscale):
      error: 1 error occurred:
      	* creating Monitor Autoscale Setting: (Name "vmss-autoscalebe79b75d" / Resource Group "vmss-rg58c1593d"): insights.AutoscaleSettingsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="SendEmailsToAdminCoAdminsNotSupported" Message="Sending email notifications to subscription administrator and coadministrators is not supported after April 3, 2024 due to Azure classic administrator retirement."

It was also a major version behind.

@thomas11 thomas11 requested review from cnunciato and a team July 1, 2024 19:50
cnunciato
cnunciato approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@thomas11 thomas11 self-assigned this Jul 2, 2024
@thomas11 thomas11 merged commit d13d0f7 into master Jul 2, 2024
48 of 51 checks passed
@thomas11 thomas11 deleted the tkappler/classic-azure-ts-vm-scaleset branch July 2, 2024 06:18
@lukehoban lukehoban mentioned this pull request Jul 8, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnunciato cnunciato cnunciato approved these changes

Assignees

@thomas11 thomas11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomas11 @cnunciato