Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dictionary literals, poetry & pyright in aws-py-fargate #1656

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Use dictionary literals, poetry & pyright in aws-py-fargate #1656

merged 2 commits into from
Jul 3, 2024

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Jul 2, 2024 •
edited
Loading

Use the latest python features from pulumi/docs#12123 in the aws-py-fargate example.

This could also go into a separate example instead of changing the existing one, not sure what we prefer here?

@julienp julienp mentioned this pull request Jul 2, 2024
Merged
@julienp julienp requested a review from a team July 2, 2024 16:18
tgummerer
tgummerer approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me to update an existing example with this.

@julienp julienp merged commit ce94281 into master Jul 3, 2024
49 of 51 checks passed
@julienp julienp deleted the julienp/python-enhancements branch July 3, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgummerer tgummerer tgummerer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienp @tgummerer