Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete performance-metrics cron job #1659

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

cnunciato
Copy link
Member

@cnunciato cnunciato commented Jul 3, 2024

As with pulumi/templates#804, this PR deletes a long-failing workflow no one seems to be using.

Fixes #1627.

@cnunciato cnunciato requested a review from a team July 3, 2024 18:36
Copy link

pulumi-staging bot commented Jul 3, 2024

🍹 The Update for pulumi/k8s-ci-cluster/5245315801c3ca03ad227b363e2591672aec28b2-1807 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-5245315801c3ca03ad227b363e2591672aec28b2-1807  pulumi:pulumi:Stack                         create
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create

Copy link

pulumi-staging bot commented Jul 3, 2024

🍹 The Update for pulumi/k8s-ci-cluster/02b13cc1c4b74185a1feb145a200a836bd109f6d-1808 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   k8s-ci-cluster-02b13cc1c4b74185a1feb145a200a836bd109f6d-1808  pulumi:pulumi:Stack                         create
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create

@t0yv0
Copy link
Member

t0yv0 commented Jul 3, 2024

Can we discuss moving this? our teams use this.

@cnunciato
Copy link
Member Author

@t0yv0 Sure -- but how do you use it?

@cnunciato
Copy link
Member Author

cnunciato commented Jul 3, 2024

@t0yv0 Just noticed your comment here, about setting these metrics up to run in another repo: pulumi/templates#804 (comment)

That sounds like the right approach to me. Since this repo (like pulumi/templates) doesn't monitor (and I suppose ultimately has no control over) the performance of the templates per se, having these metrics managed and captured elsewhere probably makes the most sense. That way, you could use any repository (or repositories) you wanted -- this one, pulumi/examples, others, etc.

@cnunciato cnunciato requested a review from a team July 3, 2024 19:27
Copy link

pulumi-staging bot commented Jul 3, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/5245315801c3ca03ad227b363e2591672aec28b2-1807 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-5245315801c3ca03ad227b363e2591672aec28b2-1807  pulumi:pulumi:Stack                         delete
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete

Copy link

pulumi-staging bot commented Jul 3, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/02b13cc1c4b74185a1feb145a200a836bd109f6d-1808 was successful.

Resource Changes

    Name                                                          Type                                        Operation
-   password                                                      random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-02b13cc1c4b74185a1feb145a200a836bd109f6d-1808  pulumi:pulumi:Stack                         delete
-   gke                                                           pulumi:providers:kubernetes                 delete
-   primary-node-pool                                             gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               delete
-   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             delete

@t0yv0
Copy link
Member

t0yv0 commented Jul 3, 2024

This system is documented in here https://github.com/pulumi/home/wiki/CLI-Performance-Metrics and Justin's and @mjeffryes team do look at alerts coming out of this system, but looks it's not robust to alerting on missing data. I think the best indeed would be to move it out to a repo where ownership is clear and we'll need to double-check that alerting on broken workflows is resulting in fixes through our ops rotation.

@t0yv0
Copy link
Member

t0yv0 commented Jul 3, 2024

Feel free to go ahead and merge in the meanwhile, we can reinstate the code through GH history.

@cnunciato cnunciato merged commit ff650c1 into master Jul 3, 2024
49 of 51 checks passed
@cnunciato cnunciato deleted the cnunciato/delete-perf-job branch July 3, 2024 20:05
@mjeffryes
Copy link
Member

filed: Reinstate workflows for performance testing examples and templates· home/3522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: Run Performance Metrics Cron Job
4 participants