Adding an azure-nextgen example for placing app service behind vnet #909
Conversation
azure-nextgen-ts-webapp-privateendpoint-vnet-injection/index.ts
Outdated
Show resolved
Hide resolved
azure-nextgen-ts-webapp-privateendpoint-vnet-injection/index.ts
Outdated
Show resolved
Hide resolved
azure-nextgen-ts-webapp-privateendpoint-vnet-injection/package.json
Outdated
Show resolved
Hide resolved
| import * as random from "@pulumi/random"; | ||
|
|
||
| const config = new pulumi.Config(); | ||
| const resourceGroupNameParam = config.require("resourceGroupNameParam"); |
There was a problem hiding this comment.
Why require the resource group name? Should we add a default? Otherwise, we need add a command to set it to the readme.
There was a problem hiding this comment.
Added a default and cleaned up a lot of the parameter cruft from the arm template conversion.
| @@ -0,0 +1,174 @@ | |||
| // Copyright 2016-2021, Pulumi Corporation. All rights reserved. | |||
|
|
|||
| import * as azure_nextgen from "@pulumi/azure-nextgen"; | |||
There was a problem hiding this comment.
Other examples use a different import style (e.g. https://github.com/pulumi/examples/blob/master/azure-nextgen-ts-aks/index.ts#L7-L8). Should we do the same here?
azure-nextgen-ts-webapp-privateendpoint-vnet-injection/index.ts
Outdated
Show resolved
Hide resolved
azure-nextgen-ts-webapp-privateendpoint-vnet-injection/index.ts
Outdated
Show resolved
Hide resolved
| // Copyright 2016-2021, Pulumi Corporation. All rights reserved. | ||
|
|
||
| // pvt DNS zone and virtual network link are only available on this version | ||
| import * as pvtnetwork from "@pulumi/azure-nextgen/network/v20180901"; |
There was a problem hiding this comment.
Does it have to be this old version? Have you tried latest for all?
| resourceGroupName: resourceGroup.name, | ||
| serverFarmId: serverfarm.id, | ||
| siteConfig: { | ||
| ftpsState: web.FtpsState.AllAllowed, |
There was a problem hiding this comment.
Do you know if we need this setting?
There was a problem hiding this comment.
No don't think so, came from the arm template.
Co-authored-by: Mikhail Shilkov <github@mikhail.io>
I was playing around with something but didn't get it to work yet. Will update the PR with a clear demonstration of the front-end -> backend interaction via the private endpoint as soon as I get it working.
Most of this is convertible with PCL now with some cleanup. Will look to get that out shortly. |
|
|
||
| const serverfarm = new web.AppServicePlan("serverfarm", { | ||
| kind: "app", | ||
| location: location, |
There was a problem hiding this comment.
If you update to 0.6.1, you can omit location property everywhere by setting the azure-nextgen:location config value.
Adding an azure-nextgen example for placing app service behind vnet
Fixes pulumi/pulumi-azure#263