-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch providers into workspace directory #69
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 33.45% 37.27% +3.82%
==========================================
Files 42 42
Lines 2571 2664 +93
==========================================
+ Hits 860 993 +133
+ Misses 1606 1565 -41
- Partials 105 106 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, definitely need this option. I think we should use the same functional arguments style as for all other options in the library rather than exposing the raw struct directly.
@danielrbradley I would argue that functional options are counter-productive in this case, because the If you're still wanting it, let me know and I'll give it a try. Thanks! |
Ok, been mulling this over a little more. Passing an argument for WorkDir to the provider assumes that the factory has to honnor it, but some implementations may well not use it. Therefore one subtle change would be to not pass in options but pass in some context about the program under test. This could be a simple interface with just a type PulumiTest interface {
Source() string
} |
Closes #65
Breaking changes:
providers.ProviderFactory
signature change to accept an abstractproviders.PulumiTest
for contextual information.providers.ResourceProviderServerFactory
signature change to acceptproviders.PulumiTest
.