Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC log parsing #86

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix gRPC log parsing #86

merged 2 commits into from
May 3, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented May 2, 2024

Using "google.golang.org/protobuf/encoding/protojson" instead of vanilla JSON solves the problem of parsing the logs correctly to a gRPC representation.

@t0yv0 t0yv0 requested review from danielrbradley and a team May 2, 2024 20:15
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 37.99%. Comparing base (3a38438) to head (c62df5f).
Report is 3 commits behind head on main.

Files Patch % Lines
grpclog/grpclog.go 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   37.35%   37.99%   +0.64%     
==========================================
  Files          43       46       +3     
  Lines        2677     2779     +102     
==========================================
+ Hits         1000     1056      +56     
- Misses       1569     1607      +38     
- Partials      108      116       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 merged commit 24a00fa into main May 3, 2024
4 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-grpc-log-parsing branch May 3, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants