Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DeleteBeforeReplace option for iam.AccountAlias #2212

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

lblackstone
Copy link
Member

Fix #2208

Each AWS account can only have one account alias defined, so proper replacement requires that the old alias be deleted first.
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda expected an SDK change, but guess the bridge must do this provider-side via reading the schema in?

@lblackstone
Copy link
Member Author

Kinda expected an SDK change, but guess the bridge must do this provider-side via reading the schema in?

Same. I dug into it, and it appears that the replacement is triggered by the provider rather than making a change in the SDKs.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone merged commit 44e6aa8 into master Nov 14, 2022
@pulumi-bot pulumi-bot deleted the lblackstone/replacement branch November 14, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws.iam.AccountAlias can't be changed
2 participants