Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling correction of fdqn to fqdn #2554

Merged

Conversation

nille
Copy link
Contributor

@nille nille commented Jun 7, 2023

Correcting minor spelling error: fdqn fqdn

nille added 3 commits June 7, 2023 23:47
Correcting minor spelling error: ~fdqn~ fqdn
Correcting minor spelling error: ~fdqn~ fqdn
Correcting minor spelling error: ~fdqn~ fqdn
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Hello and thank you for your pull request! ❤️ ✨
It looks like you're directly modifying files in the language SDKs, many of which are autogenerated.
Be sure any files you're editing do not begin with a code generation warning.
For generated files, you will need to make changes in resources.go instead, and generate the code.

@mikhailshilkov
Copy link
Member

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/6174881449

@mikhailshilkov
Copy link
Member

@nille I'm sorry for such a long delay. It looks the PR needs a rebase to satisfy our CI, could you please do that?

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@nille
Copy link
Contributor Author

nille commented Sep 14, 2023

@mikhailshilkov Done ✅

@mikhailshilkov
Copy link
Member

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/6183697087

@mikhailshilkov mikhailshilkov merged commit 89a066f into pulumi:master Sep 14, 2023
26 checks passed
@mikhailshilkov
Copy link
Member

Thank you!

@nille nille deleted the spelling-correction-of-fdqn-to-fqdn branch September 14, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants