Upgrade upstream to v5.17.0 #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
changed the title
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
lukehoban
approved these changes
Sep 18, 2023
kpitzen
approved these changes
Sep 18, 2023
t0yv0
added a commit
that referenced
this pull request
Sep 27, 2023
Unfortunately 8a12083 did not really happen as the commit didn't include ./upstream and patches changes due to human error. I've reopened 5.17.0 upgrade ticket. The provider actually remains on 5.16.2 right now. For the same reasons of go.sum conflict as in #2817 upgrade-provider continues unable to process these upgrades. I've started the process manually here again for v5.16.2..v5.18.0. Unfortunately we have a new problem here, upstream no longer compiles: ``` go build -v all github.com/hashicorp/terraform-provider-aws/internal/service/s3legacy # github.com/hashicorp/terraform-provider-aws/internal/service/s3legacy internal/service/s3legacy/bucket_legacy.go:1425:35: meta.(*conns.AWSClient).S3ConnURICleaningDisabled undefined (type *conns.AWSClient has no field or method S3ConnURICleaningDisabled) ``` We will need another patch here to carefully test deletion on the S3 bucket legacy. When complete it would be fixing: - #2812 - #2822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2812
Fixes #2806
We could not use upgrade-provider for this operation because there was a conflict between upstream changes editing a go.sum and one of our patches doing the same, so the patch did not apply cleanly. Resolved manually by rebating upstream and rebuilding the patch set.
The new upstream version targeted here is 5.17.0.
On top of the upstream upgrade, this PR updates dependencies from pulumi-terraform-bridge to propagate bugfixes: