Remove QuickSight hack in favor of bridge change #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
Does the lack of changes in the sdk mean that the change does exactly the same as manually omitting the types? |
Yes. |
iwahbe
force-pushed
the
iwahbe/example-of-bridge-pr-1548
branch
from
b63a4d2
to
d370140
Compare
iwahbe
changed the title
iwahbe
changed the title
|
This needs |
t0yv0
approved these changes
Nov 30, 2023
Taking advantage of pulumi/pulumi-terraform-bridge#1548, this PR removes the quicksight schema customizations since Omit now does the right thing on its own. This has the advantage of removing these unusable mappings from bridge-metadata.json.
iwahbe
force-pushed
the
iwahbe/example-of-bridge-pr-1548
branch
from
d370140
to
7606e1c
Compare
|
/release v6.12.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking advantage of pulumi/pulumi-terraform-bridge#1548, this PR removes the quicksight schema customizations since
Omitnow does the right thing on its own.This has the advantage of removing these unusable mappings from
bridge-metadata.json.