-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EKS service principal for Node.js SDK #3651
Conversation
Hello and thank you for your pull request! ❤️ ✨ |
PR is now waiting for a maintainer to run the acceptance tests. |
Thanks so much for pointing this out @auvred ! Unfortunately the code edited here is auto-generated and we cannot accept the change as is, but we need to track to find out why this value is not being picked up, and re-generate SDK code for all languages. I'll take a quick look. |
I checked the file history (https://github.com/pulumi/pulumi-aws/commits/master/sdk/nodejs/iam/principals.ts), and it looks like the changes that were made there were not synced with other language SDKs. Also, I couldn't find a similar Thus, it seems that this file is not autogenerated. Please correct me if I am wrong! |
You are right, my mistake, this seems to be a Node SDK overlay that is only available for Node users but is maintained manually. Your correction makes sense to include then! Thank you. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.27.0` -> `6.28.2`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.27.0/6.28.2) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.28.2`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.28.2) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.28.1...v6.28.2) ##### Changelog - [`60ee1d9`](https://togithub.com/pulumi/pulumi-aws/commit/60ee1d9972) Correctly set the alt type for `aws_cloudwatch_log_resource_policy` ([#​3743](https://togithub.com/pulumi/pulumi-aws/issues/3743)) - [`2ee8434`](https://togithub.com/pulumi/pulumi-aws/commit/2ee84343ef) Update the interface for ECS Container PortMapping with current options ([#​3043](https://togithub.com/pulumi/pulumi-aws/issues/3043)) - [`bcceea1`](https://togithub.com/pulumi/pulumi-aws/commit/bcceea1a68) Upgrade pulumi-terraform-bridge to v3.79.0 ([#​3758](https://togithub.com/pulumi/pulumi-aws/issues/3758)) - [`1ee3194`](https://togithub.com/pulumi/pulumi-aws/commit/1ee31944f4) fix: rds.dataSourceEngineVersionRead panic ([#​3757](https://togithub.com/pulumi/pulumi-aws/issues/3757)) ### [`v6.28.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.28.1) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.27.0...v6.28.1) ##### Changelog ##### What's Changed - Upstream v5.42.0 by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3728 - Add support for C7a instance types by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3734 - Remove patch for CloudWatch Logging entry in Lambda description by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [pulumi/pulumi-aws#3654 - Fix rds.ParameterGroup diff not clear [#​2442](https://togithub.com/pulumi/pulumi-aws/issues/2442) by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3638 - Remove stale doc for acm.CertificateValidation by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [pulumi/pulumi-aws#3656 - Cleanup: Update import overwrite for Network Firewall Resource Policy by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [pulumi/pulumi-aws#3676 - Fix updating tags on aws_launch_template by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3687 - Update auto-generated AWS managed IAM policies by [@​iwahbe](https://togithub.com/iwahbe) in [pulumi/pulumi-aws#3701 - Deprecation: inline rules for SecurityGroup and NetworkAcl resources by [@​EronWright](https://togithub.com/EronWright) in [pulumi/pulumi-aws#3729 - Add EKS service principal for Node.js SDK by [@​auvred](https://togithub.com/auvred) in [pulumi/pulumi-aws#3651 ##### Dependencies - Upgrade pulumi-terraform-bridge to v3.78.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [pulumi/pulumi-aws#3673 ##### New Contributors - [@​EronWright](https://togithub.com/EronWright) made their first contribution in [pulumi/pulumi-aws#3729 - [@​auvred](https://togithub.com/auvred) made their first contribution in [pulumi/pulumi-aws#3651 **Full Changelog**: pulumi/pulumi-aws@v6.27.0...v6.28.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI3Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.27.0` -> `6.28.2`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.27.0/6.28.2) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.28.2`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.28.2) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.28.1...v6.28.2) ##### Changelog - [`60ee1d9`](https://togithub.com/pulumi/pulumi-aws/commit/60ee1d9972) Correctly set the alt type for `aws_cloudwatch_log_resource_policy` ([#​3743](https://togithub.com/pulumi/pulumi-aws/issues/3743)) - [`2ee8434`](https://togithub.com/pulumi/pulumi-aws/commit/2ee84343ef) Update the interface for ECS Container PortMapping with current options ([#​3043](https://togithub.com/pulumi/pulumi-aws/issues/3043)) - [`bcceea1`](https://togithub.com/pulumi/pulumi-aws/commit/bcceea1a68) Upgrade pulumi-terraform-bridge to v3.79.0 ([#​3758](https://togithub.com/pulumi/pulumi-aws/issues/3758)) - [`1ee3194`](https://togithub.com/pulumi/pulumi-aws/commit/1ee31944f4) fix: rds.dataSourceEngineVersionRead panic ([#​3757](https://togithub.com/pulumi/pulumi-aws/issues/3757)) ### [`v6.28.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.28.1) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.27.0...v6.28.1) ##### Changelog ##### What's Changed - Upstream v5.42.0 by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3728 - Add support for C7a instance types by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3734 - Remove patch for CloudWatch Logging entry in Lambda description by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [pulumi/pulumi-aws#3654 - Fix rds.ParameterGroup diff not clear [#​2442](https://togithub.com/pulumi/pulumi-aws/issues/2442) by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3638 - Remove stale doc for acm.CertificateValidation by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [pulumi/pulumi-aws#3656 - Cleanup: Update import overwrite for Network Firewall Resource Policy by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [pulumi/pulumi-aws#3676 - Fix updating tags on aws_launch_template by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3687 - Update auto-generated AWS managed IAM policies by [@​iwahbe](https://togithub.com/iwahbe) in [pulumi/pulumi-aws#3701 - Deprecation: inline rules for SecurityGroup and NetworkAcl resources by [@​EronWright](https://togithub.com/EronWright) in [pulumi/pulumi-aws#3729 - Add EKS service principal for Node.js SDK by [@​auvred](https://togithub.com/auvred) in [pulumi/pulumi-aws#3651 ##### Dependencies - Upgrade pulumi-terraform-bridge to v3.78.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [pulumi/pulumi-aws#3673 ##### New Contributors - [@​EronWright](https://togithub.com/EronWright) made their first contribution in [pulumi/pulumi-aws#3729 - [@​auvred](https://togithub.com/auvred) made their first contribution in [pulumi/pulumi-aws#3651 **Full Changelog**: pulumi/pulumi-aws@v6.27.0...v6.28.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI3Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
eks.amazonaws.com
service principal seems to be missinghttps://docs.aws.amazon.com/eks/latest/userguide/using-service-linked-roles-eks.html#service-linked-role-permissions-eks