Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rds.dataSourceEngineVersionRead panic #3757

Merged
merged 1 commit into from
Mar 29, 2024
Merged

fix: rds.dataSourceEngineVersionRead panic #3757

merged 1 commit into from
Mar 29, 2024

Conversation

corymhall
Copy link
Contributor

This temporarily reverts the upstream change hashicorp/terraform-provider-aws@f8ab290 because we cannot currently deal with RawConfig during read.

re #3752, re pulumi/pulumi-terraform-bridge#1809

@corymhall
fix: rds.dataSourceEngineVersionRead panic
f0c638a 
This temporarily reverts the upstream change hashicorp/terraform-provider-aws@f8ab290
because we cannot currently deal with `RawConfig` during read.

re #3752, re pulumi/pulumi-terraform-bridge#1809
@corymhall corymhall requested a review from t0yv0 March 29, 2024 14:48
@github-actions GitHub Actions
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@github-actions GitHub Actions
Copy link

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

t0yv0
t0yv0 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

mikhailshilkov
mikhailshilkov reviewed Mar 29, 2024
View reviewed changes
examples/rds-getengineversion/index.ts
@@ -0,0 +1,3 @@
import * as aws from "@pulumi/aws";

export const vs = aws.rds.getEngineVersionOutput({engine: "postgres"});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tangential - but should we be defining new tests in YAML these days? @t0yv0 @mjeffryes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think the slight preference is for YAML, but the cross-testing advantages of having it in YAML are not yet realized anywhere I think.

@t0yv0 t0yv0 merged commit 1ee3194 into master Mar 29, 2024
24 checks passed
@t0yv0 t0yv0 deleted the corymhall/patch-rds-datasourceengineversion branch March 29, 2024 20:04
@mikhailshilkov mikhailshilkov mentioned this pull request Apr 1, 2024
Closed
@t0yv0 t0yv0 mentioned this pull request May 20, 2024
Open
corymhall added a commit that referenced this pull request Jun 10, 2024
@corymhall
fix: invocation of getEngineVersion returns an error
1116656 
A patch was introduced via #3757 due to [a bug in
pulumi-terraform-bridge](pulumi/pulumi-terraform-bridge#1809).

The underlying bridge issue has now been fixed so I am removing the
patch and restoring the original terraform behavior.

fixes #4043
@corymhall corymhall mentioned this pull request Jun 10, 2024
Merged
corymhall added a commit that referenced this pull request Jun 11, 2024
@corymhall
fix: invocation of getEngineVersion returns an error (#4047)
b1eae8a 
A patch was introduced via #3757 due to [a bug in

pulumi-terraform-bridge](pulumi/pulumi-terraform-bridge#1809).

The underlying bridge issue has now been fixed so I am removing the
patch and restoring the original terraform behavior.

fixes #4043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@mikhailshilkov mikhailshilkov mikhailshilkov left review comments

Assignees

@corymhall corymhall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corymhall @t0yv0 @mikhailshilkov