Skip to content

Commit

Permalink
Fix order of code generation in schema-types.ts (#1245)
Browse files Browse the repository at this point in the history
Fixes #1244

I've ran `make build provider` locally and it had the same diff as the
CI.
  • Loading branch information
t0yv0 committed Mar 26, 2024
1 parent ab733bb commit 0390f0d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion awsx/ecr/image.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function computeImageFromAsset(
args: pulumi.Unwrap<schema.ImageArgs>,
parent: pulumi.Resource,
) {
const { repositoryUrl, registryId : inputRegistryId, imageTag, ...dockerInputs } = args ?? {};
const { repositoryUrl, registryId: inputRegistryId, imageTag, ...dockerInputs } = args ?? {};

const url = new URL("https://" + repositoryUrl); // Add protocol to help it parse
const registryId = inputRegistryId ?? url.hostname.split(".")[0];
Expand Down
2 changes: 1 addition & 1 deletion awsx/schema-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ export interface ImageArgs {
readonly dockerfile?: pulumi.Input<string>;
readonly imageTag?: pulumi.Input<string>;
readonly platform?: pulumi.Input<string>;
readonly registryId?: pulumi.Input<string>;
readonly repositoryUrl: pulumi.Input<string>;
readonly target?: pulumi.Input<string>;
readonly registryId?: pulumi.Input<string>;
}
export abstract class Repository<TData = any> extends (pulumi.ComponentResource)<TData> {
public lifecyclePolicy?: aws.ecr.LifecyclePolicy | pulumi.Output<aws.ecr.LifecyclePolicy>;
Expand Down

0 comments on commit 0390f0d

Please sign in to comment.