Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi_awsx python package dependency on setuptools.pkg_resources #1262

Closed
daroczig opened this issue Apr 12, 2024 · 3 comments · Fixed by #1266
Closed

pulumi_awsx python package dependency on setuptools.pkg_resources #1262

daroczig opened this issue Apr 12, 2024 · 3 comments · Fixed by #1266
Assignees
Labels
impact/panic This bug represents a panic or unexpected crash kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone

Comments

@daroczig
Copy link

What happened?

Trying to use the pulumi_awsx Python package without setuptools installed raises the below exception:

Diagnostics:
    pulumi:pulumi:Stack (spare-cores-dev):
      error: Program failed with an unhandled exception:
      Traceback (most recent call last):
        File "/home/runner/work/sc-infra/sc-infra/dev/spare-cores/__main__.py", line 4, in <module>
          import pulumi_awsx as awsx
        File "/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/pulumi_awsx/__init__.py", line 5, in <module>
          from . import _utilities
        File "/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/pulumi_awsx/_utilities.py", line 10, in <module>
          import pkg_resources
      ModuleNotFoundError: No module named 'pkg_resources'

Example

  1. Install pulumi_awsx without setuptools (that is not a dependency)
  2. Try to use it

Output of pulumi about

CLI          
Version      3.111.1
Go Version   go1.22.1
Go Compiler  gc

Host     
OS       arch
Version  "rolling"
Arch     x86_64

Backend        
Name           pulumi.com
URL            https://app.pulumi.com
User           Unknown
Organizations  
Token type     personal

Additional context

Same issue as in pulumi/pulumi#12414 but for awsx this time instead of aws.

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@daroczig daroczig added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Apr 12, 2024
@justinvp
Copy link
Member

Thanks for opening the issue @daroczig! Looks like awsx needs to upgrade to a more recent version of pulumi's codegen libraries for its generated SDK. Moving this issue to the awsx repo for further triage.

@justinvp justinvp transferred this issue from pulumi/pulumi Apr 15, 2024
@t0yv0
Copy link
Member

t0yv0 commented Apr 15, 2024

Thanks @justinvp and @daroczig , we'll follow up to make sure we're consistently up to date.

@t0yv0 t0yv0 added this to the 0.104 milestone Apr 15, 2024
@t0yv0 t0yv0 added size/S Estimated effort to complete (1-2 days). and removed needs-triage Needs attention from the triage team labels Apr 15, 2024
@mikhailshilkov
Copy link
Member

@t0yv0 This sounds bad, I'm marking it as p1 as a panic (exception)

@mikhailshilkov mikhailshilkov added p1 A bug severe enough to be the next item assigned to an engineer impact/regression Something that used to work, but is now broken labels Apr 17, 2024
@t0yv0 t0yv0 self-assigned this Apr 17, 2024
t0yv0 added a commit that referenced this issue Apr 18, 2024
Fixes #1262 by updating code
generator dependency from pulumi/pulumi to the latest version.

Provider upgrade tests are updated to the latest version of
https://github.com/pulumi/providertest with skips cross-referencing
issues.

The acceptance test job started failing with out-of-disk-space; to
compensate for the moment a disk cleanup step is added to free more disk
space on the runner.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 18, 2024
@mjeffryes mjeffryes added impact/panic This bug represents a panic or unexpected crash and removed impact/regression Something that used to work, but is now broken labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/panic This bug represents a panic or unexpected crash kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants