Enable more VPC upgrade tests #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/ts-lb-simple/index.ts
Outdated
| "awslogs-region": "us-west-2", | ||
| "awslogs-stream-prefix": "my-app", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Do we need these changes? cc: @thomas11
There was a problem hiding this comment.
Without them, the container wouldn't start for me when running the tests locally, with error
There was an error while retrieving logs from log stream: nginx/nginx/8c06c430fc784875b8f5c28c0e9b5101 in log group: my-service-d975f63.
The specified log stream does not exist.
I didn't fully chase it down. Since it seems to work in CI, another region/account difference?
danielrbradley
approved these changes
Nov 2, 2023
mikhailshilkov
force-pushed
the
mikhailshilkov/more-upgrade-tests
branch
from
eb6e898
to
bb86cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few more snapshot tests
Supersedes #1119 (rebased on 2.1.0)