Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate subnet tags for explicit strategy #1288

Merged
merged 1 commit into from
May 13, 2024

Conversation

flostadler
Copy link
Contributor

@flostadler flostadler commented May 13, 2024

Previously when using the explicit subnet distribution strategy (i.e. when specifying specific subnet CIDRs) the tags didn't get propagated to the subnet. This fixes that.

Fixes #1287

Previously when using the explicit subnet distribution strategy (i.e. when
specifying specific subnet CIDRs) the tags didn't get propagated to the
subnet.
This fixes that.
@flostadler flostadler requested review from t0yv0, corymhall and a team May 13, 2024 08:34
@flostadler flostadler self-assigned this May 13, 2024
@flostadler flostadler merged commit 18bd13b into master May 13, 2024
10 checks passed
@flostadler flostadler deleted the 1287-explicit-subnet-missing-tags branch May 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awsx.ec2.Vpc does not apply tags from subnet_specs if subnet_strategy=awsx.ec2.SubnetAllocationStrategy.AUTO
3 participants