[arm2pulumi] - Adds input validation for expected languages to render #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example output: |
kpitzen
force-pushed
the
KP/Validatearm2pulumilang
branch
from
e4ff7b2
to
d75aba9
Compare
kpitzen
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
thomas11
reviewed
May 4, 2023
| @@ -30,6 +30,22 @@ import ( | |||
| "github.com/sourcegraph/jsonx" | |||
| ) | |||
|
|
|||
| var SupportedLanguages = map[string]interface{}{ | |||
There was a problem hiding this comment.
Just a note: a bit unfortunate that we have to repeat (and later update) the list here when we already import p/p. I just looked around briefly but it doesn't seem we have any exported, official set of languages there.
There was a problem hiding this comment.
Totally agree - I looked for exactly this and came up unfortunately empty-handed. Maybe worth opening an issue on p/p?
thomas11
approved these changes
May 4, 2023
- Adds a set of supported languages in pkg/arm2pulumi/renderer.go - Validates all provided languages in cmd/arm2pulumi/main.go - Provides dynamic list of possible languages in the primary prompt help
kpitzen
force-pushed
the
KP/Validatearm2pulumilang
branch
from
d75aba9
to
10ef6d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes pulumi/arm2pulumi#32