Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the special behavior of updating sql.Server passwords #3242

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

thomas11
Copy link
Contributor

This documentation intends to help users when encountering this surprising behavior and addresses #2937 at least in the short-medium term.

I'm not a native speaker so please feel free to suggest changes.

@thomas11 thomas11 requested review from danielrbradley and a team April 26, 2024 15:16
@thomas11 thomas11 self-assigned this Apr 26, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@danielrbradley
Copy link
Member

Does this not update the schema because we don't commit the one with the docs included?

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.34%. Comparing base (1adf471) to head (d485f3a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3242      +/-   ##
==========================================
- Coverage   55.49%   55.34%   -0.16%     
==========================================
  Files          66       66              
  Lines        9929     9929              
==========================================
- Hits         5510     5495      -15     
- Misses       3991     4001      +10     
- Partials      428      433       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11
Copy link
Contributor Author

Does this not update the schema because we don't commit the one with the docs included?

Exactly. Here's the registry preview for the change.

@thomas11 thomas11 merged commit 9b47251 into master Apr 29, 2024
24 checks passed
@thomas11 thomas11 deleted the tkappler/sql-passwords branch April 29, 2024 10:10
thomas11 added a commit that referenced this pull request Apr 30, 2024
…3249)

The other changes in schema.json seem to be due to non-determinism.
_Update: this PR also contains the schema change from #3242 because I
didn't commit the changed schema.json in that PR 😬_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants