Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual pulumi/pulumi upgrade to 3.115 #3260

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented May 6, 2024

The manual upgrade was necessary due to an API change in dotnetgen.GeneratePackage. Confirmed with @Frassle that nil is ok here.

@thomas11 thomas11 requested review from a team and danielrbradley May 6, 2024 07:35
Copy link

github-actions bot commented May 6, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.37%. Comparing base (10cc13d) to head (edbd1ae).

Files Patch % Lines
provider/cmd/pulumi-gen-azure-native/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3260   +/-   ##
=======================================
  Coverage   55.37%   55.37%           
=======================================
  Files          66       66           
  Lines        9924     9924           
=======================================
  Hits         5495     5495           
  Misses       3996     3996           
  Partials      433      433           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 enabled auto-merge (squash) May 6, 2024 12:06
Copy link

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomas11 thomas11 merged commit 24a4e6a into master May 6, 2024
24 checks passed
@thomas11 thomas11 deleted the tkappler/upgrade-pulumi branch May 6, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants