Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRC test failures in pulumi-azure #2322

Closed
3 tasks done
VenelinMartinov opened this issue Aug 15, 2024 · 5 comments · Fixed by #2306
Closed
3 tasks done

PRC test failures in pulumi-azure #2322

VenelinMartinov opened this issue Aug 15, 2024 · 5 comments · Fixed by #2306
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Aug 15, 2024

Describe what happened

A few tests fail under PRC in pulumi-azure:

Part of pulumi/pulumi-terraform-bridge#1785

Sample program

https://github.com/pulumi/pulumi-azure/actions/runs/10178181276/job/28152031872?pr=2306

Log output

No response

Affected Resource(s)

No response

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label Aug 15, 2024
@VenelinMartinov VenelinMartinov self-assigned this Aug 15, 2024
@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Aug 15, 2024

The subnet issue is #2323 - this one reproes in terraform, so PRC is technically more truthful to the underlying provider.

We might still want to address it though.

Addressed in #2325

@VenelinMartinov
Copy link
Contributor Author

#2333 has a GRPC repro for the empty diff observed in TestAccAciVolumeMount.
I've had some trouble reproing manually.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Aug 19, 2024

Debugging this a bit more here is the content of the tf instance diff:

Attributes: map[string]*terraform.ResourceAttrDiff{
			"network_rule_set.#": *terraform.ResourceAttrDiff{
				Old: "", New: "", NewComputed: true, NewRemoved: false, NewExtra: interface{}(nil), RequiresNew: false, Sensitive: false, Type: 0x0,
			},
		}

On the pulumi side, detailed diff and collection diff are empty.

@t0yv0
Copy link
Member

t0yv0 commented Aug 19, 2024

"network_rule_set.#" and NewComputed: true

This tells me that the number of set elements is unknown. Can you lift to a dedicated issue? Can be interesting.

@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2306 and shipped in release v5.88.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants