Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure.operationalinsights.AnalyticsWorkspace error when dailyQuotaGb is not set #784

Closed
boillodmanuel opened this issue Dec 7, 2020 · 4 comments
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@boillodmanuel
Copy link

boillodmanuel commented Dec 7, 2020

Version: @pulumi/azure v3.32.0

If dailyQuotaGb is not set, we got the following error :

    error: azure:operationalinsights/analyticsWorkspace:AnalyticsWorkspace resource 'aw' has a problem: expected daily_quota_gb to be at least (0.000000), got -1.000000

Terraform supports it (but does not support to explictly set -1, so I opened an issue for that hashicorp/terraform-provider-azurerm#9732)

Code:

new azure.operationalinsights.AnalyticsWorkspace("aw", {
    name: "log-aw-xyz",
    resourceGroupName: "rg-aw",
    retentionInDays: 30,
    sku: "PerGB2018",
})

Terraform behaviour :

  • when a value is set, it should be > 0
  • when no value is set, it defaults to -1

A bit weird IMHO (it's why I open an issue)

@boillodmanuel
Copy link
Author

Related to #783
This issue (#784) is the root cause, and #783 is the issue I had after trying to downgrade to a previous version

@gpduck
Copy link

gpduck commented Feb 3, 2021

Just hit this as well. Looking in to it, should the terraform resource just not be specifying a default value of -1?

https://github.com/terraform-providers/terraform-provider-azurerm/blob/82b73af7a3319e3abb2bc1eb083be86941e9e9ab/azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go#L99-L105

It seems silly to set a default value and then a validator function that says that value is invalid.

@boillodmanuel
Copy link
Author

Totally agree! I opened an issue for that, cf my first comment, but they closed it

@mikhailshilkov mikhailshilkov added the resolution/fixed This issue was fixed label Mar 31, 2023
@mikhailshilkov
Copy link
Member

Tested with 5.38.0 and it works now, closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants