Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent runs of the test suite fail #39

Open
viveklak opened this issue May 3, 2022 · 1 comment
Open

Concurrent runs of the test suite fail #39

viveklak opened this issue May 3, 2022 · 1 comment
Labels
kind/engineering Work that is not visible to an external user

Comments

@viveklak
Copy link
Contributor

viveklak commented May 3, 2022

Some resources seem to have fixed names which can collide if concurrent runs occur, e.g.:

aws:lb:TargetGroup (LBListenerTargetGroupF04FCF6D):
      error: 1 error occurred:
      	* error creating LB Target Group: DuplicateTargetGroupName: A target group with the same name 'LBListenerTargetGroupF04FCF6D' exists, but with different settings
      	status code: 400, request id: 7e4ad2d9-bb3b-4f45-aa1f-507f8355a098

For the time being concurrency has been dropped to 1 here: ad5922e.

We should revisit if autonaming can be safely honored on resources corresponding to the L1 CDK constructs to make this moot.
@viveklak viveklak added the kind/engineering Work that is not visible to an external user label May 3, 2022
@jkisk
Copy link
Contributor

jkisk commented May 25, 2022

making a test comment to validate that we have fixed #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viveklak @jkisk