Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub actions triggering on comments #50

Closed
fitzoh opened this issue May 23, 2022 · 0 comments · Fixed by #51
Closed

Fix GitHub actions triggering on comments #50

fitzoh opened this issue May 23, 2022 · 0 comments · Fixed by #51
Assignees
@jkisk
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.73

Comments

@fitzoh
Copy link

fitzoh commented May 23, 2022 •
edited

I commented on #49, then I received an email that my action had failed.
This was surprising. (link)

It looks like there's an action being run on comment that's failing:
Screen Shot 2022-05-23 at 3 47 43 PM

It looks like this workflow is misconfigured to run acceptance tests on issue comments?
cc @pgavlin
@jkisk jkisk mentioned this issue May 25, 2022
Merged
@jkisk jkisk closed this as completed in #51 May 25, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label May 25, 2022
@jkisk jkisk mentioned this issue May 25, 2022
Open
@jkisk jkisk self-assigned this May 25, 2022
@jkisk jkisk added the kind/bug Some behavior is incorrect or out of spec label May 25, 2022
@jkisk jkisk added this to the 0.73 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkisk jkisk

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.73
Development

Successfully merging a pull request may close this issue.

Fix command-dispatch and add conditional to only run on pr comments pulumi/pulumi-cdk
3 participants
@fitzoh @pulumi-bot @jkisk