add oracle cloud cli to image #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannicandido
force-pushed
the
main
branch
from
1f4d83f
to
38894be
Compare
|
/run-acceptance-tests |
justinvp
added a commit
that referenced
this pull request
May 24, 2024
This reverts commit ddce061. Installing the Oracle CLI the way we're installing it is causing `/root/.bashrc` to be modified to include `/usr/bin` (the location where the `oci` binary is placed) at the front of `PATH`, _before_ `/usr/local/bin`. This ends up breaking `python3 -m venv venv` called from Pulumi Deployments because it ends up using the system Python at `/usr/bin/python3` rather than the version of Python from this image that should be used at `/usr/local/bin/python3` (due to the `PATH` change in `.bashrc`), and the system Python does not have `venv` available. It may be possible to address this by installing the Oracle CLI binary in `/usr/local/bin` rather than `/usr/bin`, but I'd like to see if it's possible to install the Oracle CLI without updating `.bashrc` at all, so reverting this in the meantime.
justinvp
added a commit
that referenced
this pull request
May 24, 2024
This reverts commit ddce061. Installing the Oracle CLI the way we're installing it is causing `/root/.bashrc` to be modified to include `/usr/bin` (the location where the `oci` binary is placed) at the front of `PATH`, _before_ `/usr/local/bin`. This ends up breaking `python3 -m venv venv` called from Pulumi Deployments because it ends up using the system Python at `/usr/bin/python3` rather than the version of Python from this image that should be used at `/usr/local/bin/python3` (due to the `PATH` change in `.bashrc`), and the system Python does not have `venv` available. It may be possible to address this by installing the Oracle CLI binary in `/usr/local/bin` rather than `/usr/bin`, but I'd like to see if it's possible to install the Oracle CLI without updating `.bashrc` at all, so reverting this in the meantime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward contribution that I need for my own stuff.
Using Oracle Cloud Kubernetes engine with pulumi requires one of the following:
The second option connects with Kubernetes using short-lived tokens emitted by the oci-cli executable. The executable will use a config file and a pem file in the ~/.oci folder (but can be configured in other ways if needed); then we can configure ~/.kube/config to use the CLI to emit the tokens.
I need this CLI installed to use in the Pulumi cloud deployments feature with native OCI authentication, as explained in the second option.
It's better to have this upstream, but I can also maintain a custom image build from the main image.
Thanks.