add java docker container #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixler
force-pushed
the
dixler/529/docker-java
branch
from
1da0b91
to
bd26da0
Compare
jkodroff
approved these changes
Jun 2, 2022
docker/pulumi/Dockerfile
Outdated
| # Install Java | ||
| RUN apt-get update -y && \ | ||
| apt-get install -y \ | ||
| maven |
There was a problem hiding this comment.
For readability, suggest either indenting this b/c it's a param of the previous line, or merging into the previous line.
jkodroff
reviewed
Jun 2, 2022
docker/java/Dockerfile
Outdated
|
|
||
| RUN apt-get update -y && \ | ||
| apt-get install -y \ | ||
| java-common \ |
There was a problem hiding this comment.
Same suggestion: either indent or put all on one line.
dixler
force-pushed
the
dixler/529/docker-java
branch
from
d630cb4
to
9cac395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a java docker image.
Fixes #88
Fixes pulumi/pulumi-java#529