Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for --ssh in Pulumi Docker V4.x.x #761

Closed
Tracked by #963
willgiang147 opened this issue Sep 25, 2023 · 1 comment
Closed
Tracked by #963

Add support for --ssh in Pulumi Docker V4.x.x #761

willgiang147 opened this issue Sep 25, 2023 · 1 comment
Assignees
@blampe
Labels
4.x.x help-wanted We'd love your contributions on this issue kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue resolution/wont-fix This issue won't be fixed

Comments

@willgiang147
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

In Pulumi Docker V4, the extraOptions field was removed from docker.DockerBuild. We are currently pinned on V3 since we rely on the --ssh flag to be passed into the docker build context so that we can clone and install dependencies from private git repos. This problem has also been echoed in #424 (comment) and #539 (for --secret)

Similar to what was done for Build.Platform, Build.Target, and Build.CacheFrom it would be great for us if the --ssh flag could be moved to a top-level field as well.

Thank you!

Affected area/feature
@willgiang147 willgiang147 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Sep 25, 2023
@mikhailshilkov mikhailshilkov added help-wanted We'd love your contributions on this issue 4.x.x and removed needs-triage Needs attention from the triage team labels Sep 25, 2023
@uatach uatach mentioned this issue Nov 9, 2023
Closed
@blampe blampe mentioned this issue Nov 29, 2023
Merged
blampe added a commit that referenced this issue Jan 29, 2024
@blampe
Add --network and --add-host to Image (#867)
d006c5a 
This adds `--network` and `--add-host` options since those are supported
by both builders.

(Other requests like #761 will require more thought, since that
functionality isn't supported in the v1 API we're using right now.)

Two integration tests are included to ensure the behavior with v1 and v2
builders.

While I was in here I also added `platform` as an output.

Fixes #837.
Fixes #862.
@blampe blampe mentioned this issue Apr 25, 2024
Closed
@blampe blampe added resolution/wont-fix This issue won't be fixed resolution/duplicate This issue is a duplicate of another issue labels Apr 25, 2024
@blampe
Copy link
Contributor

blampe commented Apr 25, 2024

See my note here about the new Docker Build provider #424 (comment)

@blampe blampe closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blampe blampe

Labels
4.x.x help-wanted We'd love your contributions on this issue kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue resolution/wont-fix This issue won't be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blampe @mikhailshilkov @willgiang147