Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Image.repoDigest output #530

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Restore Image.repoDigest output #530

merged 3 commits into from
Mar 20, 2023

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Mar 11, 2023

The Image.repoDigest property was removed in v4 as part of the transition to use the Docker SDK instead of the Docker CLI. Fortunately the SDK exposes a method that makes it easy to construct the repo digest.

Fix #507.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@benesch benesch mentioned this pull request Mar 11, 2023
Closed
AaronFriel
AaronFriel reviewed Mar 12, 2023
View reviewed changes
provider/resources.go Outdated Show resolved Hide resolved
AaronFriel
AaronFriel previously requested changes Mar 12, 2023
View reviewed changes
provider/image.go Outdated Show resolved Hide resolved
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

AaronFriel
AaronFriel reviewed Mar 16, 2023
View reviewed changes
examples/examples_nodejs_test.go
Comment on lines +74 to +78
ExtraRuntimeValidation: func(t *testing.T, stack integration.RuntimeValidationStackInfo) {
digest, ok := stack.Outputs["repoDigest"].(string)
assert.True(t, ok)
assert.NotEmpty(t, digest)
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guineveresaenger added an assertion here

@guineveresaenger
Copy link
Contributor

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-docker/actions/runs/4440579373

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@AaronFriel
Copy link
Member

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-docker/actions/runs/4441968511

@guineveresaenger
Copy link
Contributor

I looked at the test again, and the output is definitely v4 output now.
We are seeing a type assertion error in Python
AssertionError: Unexpected type; expected a value of type<class 'str'>but got a value of type<class 'dict'>at resourcemy-image, property repo_digest: {}

guineveresaenger
guineveresaenger previously requested changes Mar 17, 2023
View reviewed changes
provider/image.go Outdated Show resolved Hide resolved
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

benesch and others added 3 commits March 19, 2023 18:15
@benesch @AaronFriel
Restore Image.repoDigest output
7f5a992 
The Image.repoDigest property was removed in v4 as part of the
transition to use the Docker SDK instead of the Docker CLI. Fortunately
the SDK exposes a method that makes it easy to construct the repo
digest.

Fix pulumi#507.

Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
@AaronFriel
examples: update examples to use docker v4
af110e1
@AaronFriel
fix: Use built SDK for examples tests
db12af4
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@AaronFriel
Copy link
Member

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-docker/actions/runs/4464049883

@AaronFriel AaronFriel merged commit 1e0e8ac into pulumi:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronFriel AaronFriel AaronFriel left review comments

@guineveresaenger guineveresaenger guineveresaenger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add repo digests as outputs
4 participants
@benesch @guineveresaenger @pulumi-bot @AaronFriel