Always assume Linux for host OS #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
AaronFriel
approved these changes
Mar 14, 2023
Comment on lines
+128
to
131
| // OS defaults to Linux in all cases | ||
| os := "linux" | ||
| arch := runtime.GOARCH | ||
| hostPlatform := os + "/" + arch |
There was a problem hiding this comment.
I wonder if we could peek into the moby/moby repo or docker/cli and see what their logic is. If they infer a platform value, should we import their method?
There was a problem hiding this comment.
Ah! I did verify that on macOS with an empty platform string, the daemon does assume reasonable OS defaults, i.e. linux on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out even Windows builds for Linux by default when using Docker.
This PR leaves the logic for architecture, but defaults to use Linux as the platform OS.
Fixes #534