Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create instanceRole per-nodegroup not per-cluster #82

Closed
lukehoban opened this issue Mar 22, 2019 · 1 comment · Fixed by #98
Closed

Create instanceRole per-nodegroup not per-cluster #82

lukehoban opened this issue Mar 22, 2019 · 1 comment · Fixed by #98
Assignees
Labels
p0 A bug severe enough to interrupt existing work
Milestone

Comments

@lukehoban
Copy link
Member

Currently we are creating an instance role per cluster which is reused for each NodeGroup. This is not always sufficient, there are cases where different NodeGroups want different Roles. The default policies will be the same for each of these roles, but users may want to attach additional policies themselves to only some NodeGroups.

This also more closely aligns with the documentation and CloudFormation template used by EKS:

@lukehoban lukehoban added this to the 0.22 milestone Mar 25, 2019
@naineel
Copy link
Contributor

naineel commented Apr 1, 2019

We are still blocked on this. What's the timeline on the release of 0.22 ?

metral added a commit that referenced this issue Apr 2, 2019
metral added a commit that referenced this issue Apr 2, 2019
metral added a commit that referenced this issue Apr 2, 2019
metral added a commit to metral/pulumi-eks that referenced this issue Apr 3, 2019
metral added a commit to metral/pulumi-eks that referenced this issue Apr 3, 2019
@metral metral closed this as completed in #98 Apr 8, 2019
@infin8x infin8x added the p0 A bug severe enough to interrupt existing work label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0 A bug severe enough to interrupt existing work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants