Expand nodejs SDK tests coverage, and add Kubernetes Smoke Tests for examples & tests #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
added a commit
that referenced
this pull request
May 14, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
3428a65
to
a1a91b9
Compare
metral
added a commit
that referenced
this pull request
May 14, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
a1a91b9
to
a8f40ef
Compare
metral
added a commit
that referenced
this pull request
May 14, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
a8f40ef
to
5d2f6d2
Compare
metral
added a commit
that referenced
this pull request
May 14, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
5d2f6d2
to
2c5349c
Compare
metral
added a commit
that referenced
this pull request
May 14, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
2c5349c
to
ece59f2
Compare
metral
added a commit
that referenced
this pull request
May 15, 2019
lblackstone
reviewed
May 15, 2019
metral
added a commit
to metral/pulumi-eks
that referenced
this pull request
May 16, 2019
metral
added a commit
to metral/pulumi-eks
that referenced
this pull request
May 16, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
2 times, most recently
from
713dc66
to
cd51821
Compare
metral
added a commit
that referenced
this pull request
May 16, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
cd51821
to
2752051
Compare
metral
added a commit
that referenced
this pull request
May 16, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
2752051
to
65ad3b1
Compare
metral
added a commit
that referenced
this pull request
May 16, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
65ad3b1
to
0eb379e
Compare
metral
added a commit
that referenced
this pull request
May 16, 2019
hausdorff
reviewed
May 16, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
4670ee4
to
b72f235
Compare
metral
added a commit
that referenced
this pull request
May 17, 2019
|
@lblackstone Feedback has been addressed. PTAL |
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
b72f235
to
e9389a8
Compare
metral
added a commit
that referenced
this pull request
May 17, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
e9389a8
to
10b75e4
Compare
metral
added a commit
that referenced
this pull request
May 17, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
10b75e4
to
ca58917
Compare
metral
added a commit
that referenced
this pull request
May 17, 2019
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
ca58917
to
3a8d97c
Compare
metral
added a commit
that referenced
this pull request
May 17, 2019
3 tasks
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
3a8d97c
to
1291e4d
Compare
metral
added a commit
that referenced
this pull request
May 18, 2019
- `AssertEKSConfigMapReady`: validates `aws-auth` ConfigMap exists and has data. - `AssertAllNodesReady`: validates all nodes are running & ready. - `AssertAllPodsReady`: validates all pods are running & ready.
Note: this test works, but it is currently disabled until issue 107 is resolved.
metral
force-pushed
the
metral/improve-nodejs-tests
branch
from
1291e4d
to
5c948bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It is suggested to review this PR by commits instead of files, as they were structured to ease reading.
This PR adds better test coverage for the nodejs SDK, and a set of general utilities to perform Kubernetes Smoke Tests to validate that clusters are in fact up, running, and ready for use - coverage we were lacking to date, and at times creating false positives of fixes in the
masterbranch.Ref: #124.
replace-secgrouphas been added.add-more-subnetsis pending a fix, but its test is included in this PR for review, even though it is not being currently exec'd on test runs. This will be enabled in a future PR once the issue is resolved.upgrade-from-latestis being left for another PR.Check out the sample test output or the Travis build output showcasing the new k8s smoke tests against
examplesand the newtestsdir.