refactor(nodeSecurityGroup): expose creation, and consolidate rules #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
changed the title
metral
changed the title
metral
changed the title
metral
force-pushed
the
metral/refactor-nodesecgroup
branch
from
11b0725
to
75d5552
Compare
metral
force-pushed
the
metral/refactor-nodesecgroup
branch
from
75d5552
to
90604b0
Compare
metral
force-pushed
the
metral/refactor-nodesecgroup
branch
from
90604b0
to
90cf7ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
createNodeSecurityGroup()in the API for external use.createNodeSecurityGroup()to create theeksClusterIngressRulealongside the rest of the secgroup rules, and consolidate all rule creation.