Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for cluster endpoint #193

Merged
merged 4 commits into from
Jul 4, 2019
Merged

Wait for cluster endpoint #193

merged 4 commits into from
Jul 4, 2019

Conversation

lukehoban
Copy link
Member

@lukehoban lukehoban commented Jul 3, 2019

Wait for up to 300 seconds for cluster endpoint to be reachable.

Fixes #65.

Try out sleeping for 10s to see if that addresses availability issues.  If so, we likely want to make a more correct fix to poll the API endpoint instead.
Instead of always waiting 5 minutes, instead try to hit the cluster endpoint every 5 seconds, continuing on as soon as we can.  If we still can't reach it after 5 minutes, we allow the operation to continue (presumably to fail on some other operation).
@lukehoban lukehoban requested a review from metral July 3, 2019 23:59
@lukehoban lukehoban added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jul 3, 2019
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
@metral metral merged commit 363a748 into master Jul 4, 2019
@pulumi-bot pulumi-bot deleted the lukehoban/wait branch July 4, 2019 01:31
@icereed
Copy link

icereed commented Feb 18, 2020

Hi there, could it be that this polling is not respecting the http_proxy setting?

@metral
Copy link
Contributor

metral commented Mar 30, 2020

@icereed proxy support is being tracked in #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures to kubectl apply
3 participants