Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(eks-migration): add e2e test of migrating node groups with zero downtime #195

Merged
merged 1 commit into from
Jul 18, 2019
Merged

test(eks-migration): add e2e test of migrating node groups with zero downtime #195

merged 1 commit into from
Jul 18, 2019

Conversation

metral
Copy link
Contributor

@metral metral commented Jul 11, 2019 •
edited
Loading

Resolves #40

Related:
Tutorial PR: pulumi/docs#1327
Blog Post PR: pulumi/docs#1328

@metral metral force-pushed the metral/migrate-nodegroups branch from 5798673 to f397aad Compare July 11, 2019 21:44
@metral metral requested a review from lblackstone July 11, 2019 21:49
This was referenced Jul 11, 2019
Merged
Merged
@metral metral requested a review from lukehoban July 11, 2019 22:25
lblackstone
lblackstone requested changes Jul 11, 2019
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall

nodejs/eks/examples/migrate-nodegroups/echoserver.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/migrate-nodegroups/echoserver.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/migrate-nodegroups/echoserver.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/migrate-nodegroups/index.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/migrate-nodegroups/index.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/migrate-nodegroups/nginx-ing-cntlr.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/migrate-nodegroups/nginx.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/migrate-nodegroups/nginx.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/migrate-nodegroups/steps/step1/index.ts Outdated Show resolved Hide resolved
utils/utils.go Show resolved Hide resolved
@metral metral marked this pull request as ready for review July 12, 2019 04:54
@metral metral force-pushed the metral/migrate-nodegroups branch 5 times, most recently from 56e9c0d to 203b78d Compare July 15, 2019 21:49
@metral
Copy link
Contributor Author

metral commented Jul 15, 2019

@lblackstone Feedback has been addressed. PTAL

@lukehoban any thoughts before merging?

@metral metral force-pushed the metral/migrate-nodegroups branch 6 times, most recently from 34cbffa to 372cbef Compare July 16, 2019 21:24
@metral
Copy link
Contributor Author

metral commented Jul 16, 2019 •
edited
Loading

I've gone ahead and changed the test steps to leverage a bag of k/v's in config.ts to create the 2xlarge ng, 4xlarge ng, and defining NGINX node selector values in index.ts. This has reduced the amount of dupe code used across the test steps, and improves the readability of the test flow.

@metral metral force-pushed the metral/migrate-nodegroups branch from 372cbef to d633f6e Compare July 17, 2019 22:39
@metral metral changed the title update(eks): add example of migrating node groups with zero downtime update(eks): add e2e test of migrating node groups with zero downtime Jul 17, 2019
@metral metral changed the title update(eks): add e2e test of migrating node groups with zero downtime update(eks): add e2e test of migrating workloads across node groups with zero downtime Jul 17, 2019
@metral metral changed the title update(eks): add e2e test of migrating workloads across node groups with zero downtime update(eks): add e2e test of migrating node groups with zero downtime Jul 17, 2019
@metral metral changed the title update(eks): add e2e test of migrating node groups with zero downtime test(eks-migration): add e2e test of migrating node groups with zero downtime Jul 17, 2019
@metral
Copy link
Contributor Author

metral commented Jul 18, 2019 •
edited
Loading

@lukehoban I've addressed the feedback and simplified the testing complexity using a config bag. I've also moved this code over to examples/tests where we house the rest of our tests, given that this is a full e2e scenario being tested.

We've also added an extra step in this test to first scale down the 2xlarge node group ASG, before terminating it, as this has shown better test results with regards to the issue we occasionally hit. It seems that ENI's being leaked is related to the aws-cni, and hasn't yet been fully fixed.

PTAL and review.

lukehoban
lukehoban approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@metral metral merged commit a03df4e into master Jul 18, 2019
@pulumi-bot pulumi-bot deleted the metral/migrate-nodegroups branch July 18, 2019 01:38
This was referenced Jul 18, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone requested changes

@lukehoban lukehoban lukehoban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support worker node draining during ASG updates
3 participants
@metral @lukehoban @lblackstone