Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): sort subnets before using them in replace-cluster-add-subnets #200

Merged
merged 1 commit into from
Jul 24, 2019
Merged

fix(test): sort subnets before using them in replace-cluster-add-subnets #200

merged 1 commit into from
Jul 24, 2019

Conversation

metral
Copy link
Contributor

@metral metral commented Jul 23, 2019 •
edited
Loading

Fixes #199

@metral metral added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jul 23, 2019
@metral metral requested a review from lblackstone July 23, 2019 23:09
@metral metral force-pushed the metral/fix-replace-subnet-test branch from ae56cc2 to e119db0 Compare July 23, 2019 23:10
@metral metral merged commit 65c058b into master Jul 24, 2019
@pulumi-bot pulumi-bot deleted the metral/fix-replace-subnet-test branch July 24, 2019 00:17
@metral metral added this to the 0.25 milestone Jul 24, 2019
@metral
Copy link
Contributor Author

metral commented Aug 7, 2019

This turned out to be a dud. Need to revert the commit to remove it, as it proved unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
0.25
Development

Successfully merging this pull request may close these issues.

Empty preview step on tests is proposing changes that are not expected
2 participants
@metral @lblackstone