Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create EKS cluster & resources with IAM Role Provider #205

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

beetahnator
Copy link
Contributor

Addresses issue: #140

Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks, but overall LGTM.

This is a great PR, thank you!

I'll test this across the full test suite.

nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
@metral
Copy link
Contributor

metral commented Jul 26, 2019

Given that this PR is introducing a aws.Provider for the cluster, and it waits to assume the role, I wonder if this will temper down the IAM related issues we're seeing around role creation & assuming roles in CI: #203 & #204.

Thoughts @lukehoban ?

nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
@beetahnator
Copy link
Contributor Author

Thanks for the feedback @metral and @lukehoban

If nothing else comes up, I'll push an update this week to address the remaining concerns.

  • Make the Role & Provider optional
  • Add documentation for the Role Policy permissions

@beetahnator
Copy link
Contributor Author

beetahnator commented Aug 2, 2019

I found this issue on one of AWS's repos: aws/containers-roadmap#378

If anyone with more sway could chime in to get the [system:masters] role defined explicitly that would awesome.

For the time being I refactored the PR to be backwards compatible and added a getRoleProvider and CreationRoleProvider in case someone wanted to manually generate it.

Example usage:

  const creationRoleProvider = eks.getRoleProvider("test");

  const cluster = new eks.Cluster("test", {
    creationRoleProvider: creationRoleProvider,
    subnetIds: [...privateSubnets.ids, ...publicSubnets.ids],
    nodeSubnetIds: privateSubnets.ids,
    vpcId: vpc.id
  });

Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple of nitpicks - @lukehoban thoughts?

nodejs/eks/cluster.ts Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
@metral
Copy link
Contributor

metral commented Aug 14, 2019

Recent changes LGTM. @lukehoban PTAL

Could we also squash down to a single commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants